Bug 208157 - Prevent text selection on logo and header navigation
Summary: Prevent text selection on logo and header navigation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Davis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-24 14:33 PST by Jon Davis
Modified: 2020-02-26 14:53 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2020-02-24 14:38 PST, Jon Davis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2020-02-24 14:33:41 PST 
Prevent user selection for the WebKit website logo and header navigation elements.
Comment 1 Jon Davis 2020-02-24 14:38:22 PST 
Created attachment 391580 [details]
Patch
Comment 2 Devin Rousso 2020-02-25 14:04:17 PST 
Comment on attachment 391580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391580&action=review

r=me

> Websites/webkit.org/wp-content/themes/webkit/style.css:2103
>  header nav {

Why not put this on `header`?

Right now (with this patch), the "WebKit" next to the logo is still selectable.  Do we want that?
Comment 3 Devin Rousso 2020-02-26 14:05:08 PST 
Comment on attachment 391580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391580&action=review

>> Websites/webkit.org/wp-content/themes/webkit/style.css:2103
>>  header nav {
> 
> Why not put this on `header`?
> 
> Right now (with this patch), the "WebKit" next to the logo is still selectable.  Do we want that?

I just spoke with @Jon offline, and I misread this patch.  All good :)
Comment 4 WebKit Commit Bot 2020-02-26 14:52:48 PST 
Comment on attachment 391580 [details]
Patch

Clearing flags on attachment: 391580

Committed r257520: <https://trac.webkit.org/changeset/257520>
Comment 5 WebKit Commit Bot 2020-02-26 14:52:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-02-26 14:53:15 PST 
<rdar://problem/59822703>