Bug 208145 - Document / DOMWindow objects get leaked on CNN.com due to CSSTransitions
Summary: Document / DOMWindow objects get leaked on CNN.com due to CSSTransitions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 208069
  Show dependency tree / graph
 
Reported: 2020-02-24 10:46 PST by Chris Dumez
Modified: 2020-04-10 04:01 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.63 KB, patch)
2020-02-24 10:47 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-02-24 10:46:01 PST 
Document / DOMWindow objects get leaked on CNN.com due to CSSTransitions.
Comment 1 Chris Dumez 2020-02-24 10:47:08 PST 
Created attachment 391556 [details]
Patch
Comment 2 WebKit Commit Bot 2020-02-24 12:28:28 PST 
Comment on attachment 391556 [details]
Patch

Clearing flags on attachment: 391556

Committed r257235: <https://trac.webkit.org/changeset/257235>
Comment 3 WebKit Commit Bot 2020-02-24 12:28:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-02-24 12:29:16 PST 
<rdar://problem/59735531>
Comment 5 Antoine Quint 2020-04-10 04:01:36 PDT 
I'm having second thoughts about the change to WeakPtr<Element> for KeyframeEffect. Consider this code:

const effect = new KeyframeEffect(document.createElement("div"), {});

What will hold the assigned target alive?