Bug 207893 - REGRESSION (256034): http/tests/media/media-stream/get-display-media-prompt.html is failing
Summary: REGRESSION (256034): http/tests/media/media-stream/get-display-media-prompt.h...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-18 08:48 PST by Jacob Uphoff
Modified: 2020-02-18 10:58 PST (History)
12 users (show)

See Also:

Attachments
Diff (2.91 KB, text/plain)
2020-02-18 08:48 PST, Jacob Uphoff 		no flags Details
Patch (10.72 KB, patch)
2020-02-18 09:23 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacob Uphoff 2020-02-18 08:48:56 PST 
Created attachment 391049 [details]
Diff

http/tests/media/media-stream/get-display-media-prompt.html

This test started to fail after the revisions in 256034 

We did not catch this any sooner because there were expectations set for bug https://bugs.webkit.org/show_bug.cgi?id=206958 that were still in place after the bug there was resolved.

I caught the failure when I went to check to see if the original bug was resolved and saw the test is now constantly failing.

I was able to prove the regression came from 256034 by reproducing the failure with running the test in iterations with the command 'run-webkit-tests --root BUILD http/tests/media/media-stream/get-display-media-prompt.html -f --iterations 5000 --force'

History:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fmedia%2Fmedia-stream%2Fget-display-media-prompt.html

Diff:

See attachment
Comment 1 Radar WebKit Bug Importer 2020-02-18 08:49:25 PST 
<rdar://problem/59551315>
Comment 2 youenn fablet 2020-02-18 09:23:42 PST 
Created attachment 391056 [details]
Patch
Comment 3 WebKit Commit Bot 2020-02-18 10:58:09 PST 
Comment on attachment 391056 [details]
Patch

Clearing flags on attachment: 391056

Committed r256841: <https://trac.webkit.org/changeset/256841>
Comment 4 WebKit Commit Bot 2020-02-18 10:58:10 PST 
All reviewed patches have been landed.  Closing bug.