Bug 207879 - [LFC][TreeBuilding] Take createLineBreakBox's return value
Summary: [LFC][TreeBuilding] Take createLineBreakBox's return value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-17 20:59 PST by zalan
Modified: 2020-02-18 07:18 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.89 KB, patch)
2020-02-17 21:07 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-02-17 20:59:54 PST 
childLayoutBox = &createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle))
Comment 1 Radar WebKit Bug Importer 2020-02-17 21:00:18 PST 
<rdar://problem/59537585>
Comment 2 zalan 2020-02-17 21:07:04 PST 
Created attachment 391027 [details]
Patch
Comment 3 Antti Koivisto 2020-02-18 02:45:09 PST 
Comment on attachment 391027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391027&action=review

> Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:216
> -            createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle));
> +            childLayoutBox = &createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle));

lol
Comment 4 WebKit Commit Bot 2020-02-18 06:57:58 PST 
Comment on attachment 391027 [details]
Patch

Clearing flags on attachment: 391027

Committed r256827: <https://trac.webkit.org/changeset/256827>
Comment 5 WebKit Commit Bot 2020-02-18 06:58:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 zalan 2020-02-18 07:18:35 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 391027 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391027&action=review
> 
> > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:216
> > -            createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle));
> > +            childLayoutBox = &createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle));
> 
> lol
exactly my thoughts.