Bug 207870 - Move from "layer flush" terminology to "rendering update"
Summary: Move from "layer flush" terminology to "rendering update"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-17 16:44 PST by Simon Fraser (smfr)
Modified: 2020-02-26 14:46 PST (History)
21 users (show)

See Also:

Attachments
Patch (73.33 KB, patch)
2020-02-17 16:46 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Patch (75.76 KB, patch)
2020-02-17 17:32 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (79.06 KB, patch)
2020-02-17 18:59 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (80.30 KB, patch)
2020-02-17 23:01 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-02-17 16:44:19 PST 
Move from "layer flush" terminology to "rendering update"
Comment 1 Simon Fraser (smfr) 2020-02-17 16:46:36 PST 
Created attachment 391002 [details]
Patch
Comment 2 Tim Horton 2020-02-17 16:51:06 PST 
Comment on attachment 391002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391002&action=review

> Source/WebCore/page/ChromeClient.h:342
> +    virtual bool adjustRenderUpdateThrottling(OptionSet<RenderingUpdateThrottleState>) { return false; }

should this be an -ing?

> Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:159
> +    bool m_nextRenderingUpdateIsImmediate { false };

If we're changing the name, can we change it to something less mysterious?
Comment 3 Simon Fraser (smfr) 2020-02-17 17:32:12 PST 
Created attachment 391010 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-02-17 18:59:55 PST 
Created attachment 391020 [details]
Patch
Comment 5 Simon Fraser (smfr) 2020-02-17 23:01:45 PST 
Created attachment 391032 [details]
Patch
Comment 6 Antti Koivisto 2020-02-18 02:16:39 PST 
Comment on attachment 391032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391032&action=review

> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:211
> +        }
>  }

Weird indentation.
Comment 7 Antti Koivisto 2020-02-18 06:18:23 PST 
Is there some terminology confusion here with the HTML concept of "rendering update"? To reach visually non-empty state we need to update layout without doing any layer flushes. Should there be a concept of "visual rendering update" or similar?
Comment 8 Simon Fraser (smfr) 2020-02-18 08:10:11 PST 
(In reply to Antti Koivisto from comment #7)
> Is there some terminology confusion here with the HTML concept of "rendering
> update"?

Perhaps, but I was trying to match this terminology on purpose.

> To reach visually non-empty state we need to update layout without
> doing any layer flushes. Should there be a concept of "visual rendering
> update" or similar?

Probably!
Comment 9 WebKit Commit Bot 2020-02-18 09:24:35 PST 
Comment on attachment 391032 [details]
Patch

Clearing flags on attachment: 391032

Committed r256834: <https://trac.webkit.org/changeset/256834>
Comment 10 Radar WebKit Bug Importer 2020-02-26 14:46:15 PST 
<rdar://problem/59822371>