Bug 207865 - Rename dispatchDidReceiveEditorStateAfterFocus() to dispatchDidUpdateEditorState() to better describe its purpose
Summary: Rename dispatchDidReceiveEditorStateAfterFocus() to dispatchDidUpdateEditorSt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-17 15:19 PST by Daniel Bates
Modified: 2020-02-18 09:12 PST (History)
2 users (show)

See Also:


Attachments
Patch (9.15 KB, patch)
2020-02-17 15:24 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-02-17 15:19:26 PST
WebPageProxy::dispatchDidReceiveEditorStateAfterFocus() is called either when the WebKit receives a layer commit message or an editor state changed messaged, which may or may not be after an element is focused. Note that for all non-iOS ports WebPageProxy::dispatchDidReceiveEditorStateAfterFocus() does nothing. For iOS the implementation currently conditionalizes itself on m_waitingForPostLayoutEditorStateUpdateAfterFocusingElement because iOS defers zooming and scrolling when an element is focused until it receives an editor state update. But that is just an implementation detail of iOS. Fact remains that WebPageProxy::dispatchDidReceiveEditorStateAfterFocus() is called more often that after an element is focused.

Ideally, the iOS implementation of WebPageProxy::dispatchDidReceiveEditorStateAfterFocus() should move from WebPageProxyIOS.mm to WebPageProxy.cpp. For now, let's rename it so that it better describes its purpose.
Comment 1 Daniel Bates 2020-02-17 15:24:35 PST
Created attachment 390993 [details]
Patch
Comment 2 Daniel Bates 2020-02-17 15:26:35 PST
Thank you!
Comment 3 Daniel Bates 2020-02-18 09:11:25 PST
Comment on attachment 390993 [details]
Patch

Clearing flags on attachment: 390993

Committed r256833: <https://trac.webkit.org/changeset/256833>
Comment 4 Daniel Bates 2020-02-18 09:11:28 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-02-18 09:12:17 PST
<rdar://problem/59552009>