Bug 207794 - Add WebInspector support to WebKit::WebSocketChannel
Summary: Add WebInspector support to WebKit::WebSocketChannel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-14 14:52 PST by youenn fablet
Modified: 2020-02-17 12:47 PST (History)
12 users (show)

See Also:

Attachments
Patch (22.88 KB, patch)
2020-02-14 14:55 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (22.05 KB, patch)
2020-02-14 14:56 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (23.51 KB, patch)
2020-02-14 16:10 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (22.38 KB, patch)
2020-02-14 17:56 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (22.06 KB, patch)
2020-02-17 10:41 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-02-14 14:52:06 PST 
Add WebInspector support to WebKit::WebSocketChannel
Comment 1 youenn fablet 2020-02-14 14:55:19 PST 
Created attachment 390826 [details]
Patch
Comment 2 youenn fablet 2020-02-14 14:56:55 PST 
Created attachment 390827 [details]
Patch
Comment 3 youenn fablet 2020-02-14 16:10:48 PST 
Created attachment 390831 [details]
Patch
Comment 4 youenn fablet 2020-02-14 17:56:40 PST 
Created attachment 390845 [details]
Patch
Comment 5 Darin Adler 2020-02-16 15:54:09 PST 
Comment on attachment 390845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390845&action=review

> Source/WebCore/Modules/websockets/WebSocketChannelInspector.h:50
> +    unsigned long m_progressIdentifier { 0 };

The use of “long” here seems questionable. An unsigned is already 32 bits, just like an unsigned long.

> Source/WebKit/WebProcess/Network/WebSocketChannel.cpp:53
> +    WebSocketFrame frame(opCode, true, false, true, data, length);

Sure seems mysterious, written like this.
Comment 6 youenn fablet 2020-02-17 10:41:50 PST 
Created attachment 390936 [details]
Patch for landing
Comment 7 youenn fablet 2020-02-17 10:47:34 PST 
(In reply to Darin Adler from comment #5)
> Comment on attachment 390845 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390845&action=review
> 
> > Source/WebCore/Modules/websockets/WebSocketChannelInspector.h:50
> > +    unsigned long m_progressIdentifier { 0 };

Changed it to unsigned.

> The use of “long” here seems questionable. An unsigned is already 32 bits,
> just like an unsigned long.
> 
> > Source/WebKit/WebProcess/Network/WebSocketChannel.cpp:53
> > +    WebSocketFrame frame(opCode, true, false, true, data, length);
> 
> Sure seems mysterious, written like this.

Reused the other routine that is indeed clearer.
Comment 9 WebKit Commit Bot 2020-02-17 12:46:48 PST 
Comment on attachment 390936 [details]
Patch for landing

Clearing flags on attachment: 390936

Committed r256762: <https://trac.webkit.org/changeset/256762>
Comment 10 WebKit Commit Bot 2020-02-17 12:46:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2020-02-17 12:47:14 PST 
<rdar://problem/59522008>