Bug 207791 - Fix Highlight Range state calculations to match Selection range selections as originally intended
Summary: Fix Highlight Range state calculations to match Selection range selections as...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-14 14:23 PST by Megan Gardner
Modified: 2022-02-10 16:44 PST (History)
8 users (show)

See Also:


Attachments
Patch (2.38 KB, patch)
2020-02-14 14:31 PST, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-02-14 14:23:19 PST
Fix Highlight Range state calculations
Comment 1 Megan Gardner 2020-02-14 14:31:06 PST
Created attachment 390824 [details]
Patch
Comment 2 Tim Horton 2020-02-14 17:02:26 PST
Comment on attachment 390824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390824&action=review

> Source/WebCore/ChangeLog:3
> +        Fix Highlight Range state calculations

Not the best title. What are you fixing about them?

> Source/WebCore/ChangeLog:12
> +        Tested by existing test cases.

Why didn't their results change, then?!
Comment 3 Megan Gardner 2021-08-17 17:28:57 PDT
Code has changed around this too much. I do not believe this fix is needed any longer, or correct.