Bug 207695 - Rename SerializedPlatformRepresentation to SerializedPlatformDataCue
Summary: Rename SerializedPlatformRepresentation to SerializedPlatformDataCue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-13 07:24 PST by Eric Carlson
Modified: 2020-02-13 13:40 PST (History)
14 users (show)

See Also:

Attachments
Patch (52.50 KB, patch)
2020-02-13 07:35 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (58.87 KB, patch)
2020-02-13 08:25 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (60.06 KB, patch)
2020-02-13 08:41 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (60.04 KB, patch)
2020-02-13 08:46 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2020-02-13 07:24:53 PST 
Rename SerializedPlatformRepresentation to SerializedPlatformDataCue
Comment 1 Radar WebKit Bug Importer 2020-02-13 07:25:07 PST 
<rdar://problem/59422673>
Comment 2 Eric Carlson 2020-02-13 07:35:00 PST 
Created attachment 390641 [details]
Patch
Comment 3 Eric Carlson 2020-02-13 08:25:34 PST 
Created attachment 390647 [details]
Patch
Comment 4 youenn fablet 2020-02-13 08:29:17 PST 
Comment on attachment 390647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390647&action=review

> Source/WebCore/html/track/DataCue.cpp:119
> +    const SerializedPlatformDataCue* otherPlatformValue = dataCue->platformValue();

s/SerializedPlatformDataCue/auto/

> Source/WebCore/platform/SerializedPlatformDataCue.h:2
> + * Copyright (C) 2014 Apple Inc. All rights reserved.

2020?

> Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:38
> +class SerializedPlatformDataCueMac : public SerializedPlatformDataCue {

final?

> Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:46
> +    bool isEqual(const SerializedPlatformDataCue&) const override;

final here and above?

> Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:53
> +    SerializedPlatformDataCueMac(id nativeValue);

explicit.
Comment 5 youenn fablet 2020-02-13 08:32:03 PST 
Need to update cmake build probably
Comment 6 youenn fablet 2020-02-13 08:33:13 PST 
Source/WebCore/Headers.cmake
Comment 7 Eric Carlson 2020-02-13 08:41:03 PST 
Created attachment 390650 [details]
Patch for landing
Comment 8 Eric Carlson 2020-02-13 08:46:35 PST 
Created attachment 390652 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2020-02-13 13:40:13 PST 
Comment on attachment 390652 [details]
Patch for landing

Clearing flags on attachment: 390652

Committed r256536: <https://trac.webkit.org/changeset/256536>
Comment 10 WebKit Commit Bot 2020-02-13 13:40:15 PST 
All reviewed patches have been landed.  Closing bug.