Bug 207686 - [WPE] Add support for rendering spin buttons
Summary: [WPE] Add support for rendering spin buttons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 207471
Blocks:
  Show dependency tree / graph
 
Reported: 2020-02-13 03:10 PST by Carlos Garcia Campos
Modified: 2020-02-18 02:48 PST (History)
2 users (show)

See Also:

Attachments
Patch (11.72 KB, patch)
2020-02-13 03:15 PST, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-02-13 03:10:52 PST 
.
Comment 1 Carlos Garcia Campos 2020-02-13 03:15:27 PST 
Created attachment 390626 [details]
Patch
Comment 2 Adrian Perez 2020-02-17 15:39:02 PST 
Comment on attachment 390626 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390626&action=review

r+, but please check the comment below before landing.

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:50
> +static const unsigned menuListButtonArrowSize = 16;

Does this need to have the same value as “arrowSize“ in ThemeWPE.cpp?
If yes, please add a comment here saying so.

> Source/WebCore/platform/wpe/ThemeWPE.cpp:40
> +static const unsigned arrowSize = 16;

If this needs to have the same size as “menuListButtonArrowSize” in
RenderThemeWPE.cpp, please add a comment indicating that.
Comment 3 Carlos Garcia Campos 2020-02-18 02:48:10 PST 
(In reply to Adrian Perez from comment #2)
> Comment on attachment 390626 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390626&action=review
> 
> r+, but please check the comment below before landing.
> 
> > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:50
> > +static const unsigned menuListButtonArrowSize = 16;
> 
> Does this need to have the same value as “arrowSize“ in ThemeWPE.cpp?
> If yes, please add a comment here saying so.

Not necessarily, the arrow can be scaled, but we never scale it in case of menu list button. It's true that we don't scale it because we know the arrow size is 16 too, but still. 

> > Source/WebCore/platform/wpe/ThemeWPE.cpp:40
> > +static const unsigned arrowSize = 16;
> 
> If this needs to have the same size as “menuListButtonArrowSize” in
> RenderThemeWPE.cpp, please add a comment indicating that.
Comment 4 Carlos Garcia Campos 2020-02-18 02:48:36 PST 
Committed r256823: <https://trac.webkit.org/changeset/256823>