Bug 207671 - Add release assert for valid registration data in ServiceWorkerRegistration::getOrCreate
Summary: Add release assert for valid registration data in ServiceWorkerRegistration::...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-12 16:22 PST by youenn fablet
Modified: 2020-04-07 08:16 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.09 KB, patch)
2020-02-12 16:24 PST, youenn fablet 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-02-12 16:22:01 PST 
Add release assert for valid registration data in ServiceWorkerRegistration::getOrCreate
Comment 1 youenn fablet 2020-02-12 16:24:17 PST 
Created attachment 390585 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2020-04-07 08:16:01 PDT 
Comment on attachment 390585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390585&action=review

> Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:51
> +    RELEASE_ASSERT(!data.scopeURL.isNull());

Why not use URL::isValid() instead?