Bug 207510 - [ews] Add build-steps to close bug and clear flags on patch for commit queue in new ews
Summary: [ews] Add build-steps to close bug and clear flags on patch for commit queue ...
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-10 14:20 PST by Aakash Jain
Modified: 2021-02-19 08:56 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.34 KB, patch)
2020-02-10 14:25 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-02-10 14:20:58 PST 
Add build-steps to close bug and clear flags on patch for commit queue in new ews.
Comment 1 Aakash Jain 2020-02-10 14:25:51 PST 
Created attachment 390296 [details]
Patch
Comment 2 Aakash Jain 2020-02-10 14:28:58 PST 
Now that Bug 207492 is fixed, and layout-test step doesn't immediately finish the build, we can add these build-steps.

Sample runs:
with pre-existing failures: https://ews-build.webkit-uat.org/#/builders/26/builds/430
without failures: https://ews-build.webkit-uat.org/#/builders/26/builds/458
Comment 3 Jonathan Bedard 2020-02-10 14:38:10 PST 
Comment on attachment 390296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390296&action=review

> Tools/BuildSlaveSupport/ews-build/factories.py:223
> +        # TODO: add build-step to commit to repository here

Is this really useful to land without the commit step? Not that the code is bad, just seems not useful to land right now.

Is there a reason we want this landed now?
Comment 4 Aakash Jain 2020-03-21 03:10:06 PDT 
Implemented it in a different manner, by dynamically adding these steps wherever required. e.g.: Bug 209334 and Bug 209226