Bug 207471 - [WPE] Use custom theme style to render buttons
Summary: [WPE] Use custom theme style to render buttons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 207379
Blocks: 207686
  Show dependency tree / graph
 
Reported: 2020-02-10 09:31 PST by Carlos Garcia Campos
Modified: 2020-02-17 02:13 PST (History)
2 users (show)

See Also:

Attachments
Patch (16.64 KB, patch)
2020-02-10 09:38 PST, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-02-10 09:31:58 PST 
Push, check and radio buttons.
Comment 1 Carlos Garcia Campos 2020-02-10 09:38:40 PST 
Created attachment 390256 [details]
Patch
Comment 2 Adrian Perez 2020-02-17 01:43:48 PST 
Comment on attachment 390256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390256&action=review

I left just a small comment, otherwise LGTM :)

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:54
> +static const int menuListButtonBorderSize = 1; // Keep in sync with buttonBorderSize in Theme.

I would also add a similar comment inside “ThemeWPE.cpp” warning
“Keep in sync with menuListButtonBorderSize in RenderTheme” so no
matter which file one is editing, there's always a note to ensure
that the other one is kept in sync =)
Comment 3 Carlos Garcia Campos 2020-02-17 02:13:08 PST 
Committed r256726: <https://trac.webkit.org/changeset/256726>