WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
207448
Web Inspector: encode binary web socket frames using base64
https://bugs.webkit.org/show_bug.cgi?id=207448
Summary
Web Inspector: encode binary web socket frames using base64
Pavel Feldman
Reported
2020-02-09 18:10:41 PST
Current representation of binary frames is lossy using fromUTF8WithLatin1Fallback, we should consistently encode binary data using base64 instead.
Attachments
Patch
(10.04 KB, patch)
2020-02-09 18:23 PST
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
Patch
(10.02 KB, patch)
2020-02-09 20:22 PST
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2020-02-09 18:23:55 PST
Created
attachment 390221
[details]
Patch
EWS Watchlist
Comment 2
2020-02-09 18:24:31 PST
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Pavel Feldman
Comment 3
2020-02-09 20:22:57 PST
Created
attachment 390227
[details]
Patch
EWS
Comment 4
2020-02-12 17:20:19 PST
Comment on
attachment 390227
[details]
Patch Rejecting
attachment 390227
[details]
from commit-queue.
pfeldman@chromium.org
does not have committer permissions according to
https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json
. - If you do not have committer rights please read
http://webkit.org/coding/contributing.html
for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 5
2020-02-12 18:17:54 PST
The commit-queue encountered the following flaky tests while processing
attachment 390227
[details]
: editing/spelling/spellcheck-async-remove-frame.html
bug 158401
(authors:
morrita@google.com
,
rniwa@webkit.org
, and
tony@chromium.org
) imported/w3c/web-platform-tests/content-security-policy/script-src/scriptnonce-changed-1.html
bug 206029
(author:
psaavedra@igalia.com
) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6
2020-02-12 18:18:33 PST
Comment on
attachment 390227
[details]
Patch Clearing flags on attachment: 390227 Committed
r256497
: <
https://trac.webkit.org/changeset/256497
>
WebKit Commit Bot
Comment 7
2020-02-12 18:18:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8
2020-02-12 18:19:21 PST
<
rdar://problem/59409791
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug