Bug 207429 - [LFC][BFC] Box::isFloatAvoider should not check for isFloatingPositioned()
Summary: [LFC][BFC] Box::isFloatAvoider should not check for isFloatingPositioned()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-08 12:02 PST by zalan
Modified: 2020-02-08 13:55 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2020-02-08 12:06 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-02-08 12:02:39 PST 
it already checks for establishesBlockFormattingContext() (and floats do establish BFCs)
Comment 1 Radar WebKit Bug Importer 2020-02-08 12:03:09 PST 
<rdar://problem/59288204>
Comment 2 zalan 2020-02-08 12:06:29 PST 
Created attachment 390175 [details]
Patch
Comment 3 WebKit Commit Bot 2020-02-08 13:54:27 PST 
The commit-queue encountered the following flaky tests while processing attachment 390175 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2020-02-08 13:55:03 PST 
Comment on attachment 390175 [details]
Patch

Clearing flags on attachment: 390175

Committed r256094: <https://trac.webkit.org/changeset/256094>
Comment 5 WebKit Commit Bot 2020-02-08 13:55:04 PST 
All reviewed patches have been landed.  Closing bug.