Bug 207403 - New EWS: Retry failed builds does bot work on bug #201316
Summary: New EWS: Retry failed builds does bot work on bug #201316
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-07 13:14 PST by Daniel Bates
Modified: 2020-02-09 05:28 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-02-07 13:14:33 PST 
Today I had a look at <https://bugs.webkit.org/show_bug.cgi?id=201316> and realized that I never got EWS results from some of the bots for the my last attached patch. I pressed the "Retry failed builds" button, but it does nothing. Subsequent reloading of the page shows the button again and white EWS bubbles still link to the old build page.
Comment 1 Radar WebKit Bug Importer 2020-02-07 13:14:46 PST 
<rdar://problem/59270609>
Comment 2 Aakash Jain 2020-02-09 05:28:36 PST 
The patch (#380589) was already landed manually by the time most of EWSes processed it. So the patch was skipped on most of EWS queues.

'Retry failed builds' button do not retry the while bubbles (skipped builds), it only retry the 'failed' builds (as the name says). Please let me know if you think that this button should retry the skipped builds as well.

The relevant code is in : https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py#L306