Bug 207368 - Add a comment in StringView::setUnderlyingString(const StringView&) for clarification.
Summary: Add a comment in StringView::setUnderlyingString(const StringView&) for clari...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-06 16:48 PST by Mark Lam
Modified: 2020-02-06 17:00 PST (History)
7 users (show)

See Also:

Attachments
proposed patch. (1.72 KB, patch)
2020-02-06 16:52 PST, Mark Lam 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-02-06 16:48:31 PST 
<rdar://problem/59211075>
Comment 1 Mark Lam 2020-02-06 16:52:12 PST 
Created attachment 390029 [details]
proposed patch.
Comment 2 Keith Miller 2020-02-06 16:54:28 PST 
Comment on attachment 390029 [details]
proposed patch.

r=me.
Comment 3 Mark Lam 2020-02-06 17:00:33 PST 
Thanks for the review.  Landed in r255993: <http://trac.webkit.org/r255993>.