Bug 207323 - WEBCORE_TESTSUPPORT_EXPORT shouldn't be defined for compiling WebCore to avoid misuse
Summary: WEBCORE_TESTSUPPORT_EXPORT shouldn't be defined for compiling WebCore to avoi...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-05 23:00 PST by Fujii Hironori
Modified: 2020-02-05 23:20 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-02-05 23:00:06 PST 
WEBCORE_TESTSUPPORT_EXPORT shouldn't be defined for compiling WebCore to avoid misuse

As r252166 states, WEBCORE_TESTSUPPORT_EXPORT is used only for
WebCoreTestSupport module, but for WebCore module.

However, WEBCORE_TESTSUPPORT_EXPORT can be used
interchangeably with WEBCORE_EXPORT in almost all ports becasue
both macro definitions are exactly same, __attribute__((visibility("default"))).
Unfortunately, Windows port isn't the case.
Comment 1 Fujii Hironori 2020-02-05 23:20:48 PST 
WEBCORE_TESTSUPPORT_EXPORT was added by r180653 (Bug 141734). Its ChangeLog also says:

>    * testing/Internals.h: Use WEBCORE_TESTSUPPORT_EXPORT for things that
>    are supposed to be exported by WebCoreTestSupport, not WebCore.
>    * testing/js/WebCoreTestSupport.cpp: Add missing #include needed by