Bug 207219 - results.webkit.org: Better order upload callbacks
Summary: results.webkit.org: Better order upload callbacks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-04 12:44 PST by Jonathan Bedard
Modified: 2020-02-04 14:09 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.61 KB, patch)
2020-02-04 12:59 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-02-04 12:44:22 PST
Our upload callbacks should be ordered based on how users will interact with the data and how long the callback tasks take.
Comment 1 Jonathan Bedard 2020-02-04 12:50:46 PST
Alexey brought a bug to my attention where he was getting a 404 when trying to investigate a link to Buildbot. I couldn't reproduce the issue a few hours later, but it occurred to me what was likely happening.

Our callback tasks are executed in order, but some callback tasks are nearly instant while others may take minutes. If you look, the callback which generates links to Buildbot is executed after the one generating test results, which is the most expensive callback and the callback that tends to generate the data users most often use to discover a test run. While I can't be certain, I'm pretty sure that that what was happening to Alexey was that he followed a Buildbot link for a test run where the results had been processed (or at least, the result he was interested in) but the Buildbot links had not yet been generated.
Comment 2 Jonathan Bedard 2020-02-04 12:59:06 PST
Created attachment 389693 [details]
Patch
Comment 3 WebKit Commit Bot 2020-02-04 14:02:12 PST
Comment on attachment 389693 [details]
Patch

Clearing flags on attachment: 389693

Committed r255694: <https://trac.webkit.org/changeset/255694>
Comment 4 WebKit Commit Bot 2020-02-04 14:02:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-02-04 14:04:42 PST
<rdar://problem/59163912>
Comment 6 Jonathan Bedard 2020-02-04 14:09:11 PST
While this definitely was a theoretical issue, it wasn't what Alexey was encountering. He showed me his reproduction steps, it's a different bug.