Bug 207195 - [GTK] Context menu API tests crash in an ASSERT after r239686
Summary: [GTK] Context menu API tests crash in an ASSERT after r239686
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alejandro G. Castro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-04 06:58 PST by Alejandro G. Castro
Modified: 2020-03-03 06:29 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2020-02-04 07:02 PST, Alejandro G. Castro 		alex: review?
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2020-02-04 06:58:59 PST 
The ASSERT checks if we have mouse events but we have tests that open the context menu with the keyboard so there is no mouse event.
Comment 1 Alejandro G. Castro 2020-02-04 07:02:31 PST 
Created attachment 389655 [details]
Patch
Comment 2 Carlos Garcia Campos 2020-02-04 07:08:29 PST 
Comment on attachment 389655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389655&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:-6329
> -    ASSERT(isProcessingMouseEvents());

If this is GTK specific, add a #if !PLATFORM(GTK)
Comment 3 Alejandro G. Castro 2020-02-04 07:12:00 PST 
(In reply to Carlos Garcia Campos from comment #2)
> Comment on attachment 389655 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=389655&action=review
> 
> > Source/WebKit/UIProcess/WebPageProxy.cpp:-6329
> > -    ASSERT(isProcessingMouseEvents());
> 
> If this is GTK specific, add a #if !PLATFORM(GTK)

I had doubts if it is common to have that keyboard option to open the context menu in other platforms. I was waiting for Brian to check if it is the case for Apple.
Comment 4 Carlos Garcia Campos 2020-02-10 09:26:35 PST 
Brian?
Comment 5 Alejandro G. Castro 2020-03-03 06:29:24 PST 
Adding some reviewers to check the patch. Thanks in advance!