NEW207195
[GTK] Context menu API tests crash in an ASSERT after r239686 
https://bugs.webkit.org/show_bug.cgi?id=207195
Summary [GTK] Context menu API tests crash in an ASSERT after r239686
Alejandro G. Castro
Reported 2020-02-04 06:58:59 PST
The ASSERT checks if we have mouse events but we have tests that open the context menu with the keyboard so there is no mouse event.
Attachments
Patch (1.62 KB, patch)
2020-02-04 07:02 PST, Alejandro G. Castro 		alex: review?
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2020-02-04 07:02:31 PST
Created attachment 389655 [details] Patch
Carlos Garcia Campos
Comment 2 2020-02-04 07:08:29 PST
Comment on attachment 389655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389655&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:-6329 > - ASSERT(isProcessingMouseEvents()); If this is GTK specific, add a #if !PLATFORM(GTK)
Alejandro G. Castro
Comment 3 2020-02-04 07:12:00 PST
(In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 389655 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389655&action=review > > > Source/WebKit/UIProcess/WebPageProxy.cpp:-6329 > > - ASSERT(isProcessingMouseEvents()); > > If this is GTK specific, add a #if !PLATFORM(GTK) I had doubts if it is common to have that keyboard option to open the context menu in other platforms. I was waiting for Brian to check if it is the case for Apple.
Carlos Garcia Campos
Comment 4 2020-02-10 09:26:35 PST
Brian?
Alejandro G. Castro
Comment 5 2020-03-03 06:29:24 PST
Adding some reviewers to check the patch. Thanks in advance!
Note You need to log in before you can comment on or make changes to this bug.