Bug 207180 - Web Inspector: REGRESSION(r248287): Console: function objects saved to a $n will be invoked instead of just referenced when evaluating in the Console
Summary: Web Inspector: REGRESSION(r248287): Console: function objects saved to a $n w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 195834
Blocks:
  Show dependency tree / graph
 
Reported: 2020-02-03 19:39 PST by Devin Rousso
Modified: 2020-02-04 07:59 PST (History)
11 users (show)

See Also:

Attachments
Patch (6.72 KB, patch)
2020-02-03 19:44 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-02-03 19:39:32 PST 
# STEPS TO REPRODUCE:
1. inspect any page
2. evaluate `function foo() { return "test"; }` in the Console
3. evaluate `foo`
 => should see `$1`
4. evaluate `$1`
 => `"test"` is logged instead of `function foo() { return "test"; }`
Comment 1 Devin Rousso 2020-02-03 19:39:50 PST 
<rdar://problem/58860268>
Comment 2 Devin Rousso 2020-02-03 19:44:03 PST 
Created attachment 389620 [details]
Patch
Comment 3 Joseph Pecoraro 2020-02-03 22:23:20 PST 
Comment on attachment 389620 [details]
Patch

Nice. r=me
Comment 4 WebKit Commit Bot 2020-02-04 07:59:48 PST 
Comment on attachment 389620 [details]
Patch

Clearing flags on attachment: 389620

Committed r255675: <https://trac.webkit.org/changeset/255675>
Comment 5 WebKit Commit Bot 2020-02-04 07:59:50 PST 
All reviewed patches have been landed.  Closing bug.