Bug 207158 - [bmalloc] Add declspec support for export macros
Summary: [bmalloc] Add declspec support for export macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-03 15:32 PST by Don Olmstead
Modified: 2020-02-05 10:38 PST (History)
12 users (show)

See Also:

Attachments
Patch (8.68 KB, patch)
2020-02-03 16:00 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (8.68 KB, patch)
2020-02-03 16:06 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (8.67 KB, patch)
2020-02-03 17:04 PST, Don Olmstead 		ysuzuki: review+
Details | Formatted Diff | Diff
Patch (9.04 KB, patch)
2020-02-04 16:23 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-02-03 15:32:24 PST 
Currently just assuming *nix style exports.
Comment 1 Don Olmstead 2020-02-03 16:00:26 PST Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-02-03 16:06:01 PST Comment hidden (obsolete)
Comment 3 Don Olmstead 2020-02-03 17:04:17 PST 
Created attachment 389605 [details]
Patch
Comment 4 Yusuke Suzuki 2020-02-04 12:39:38 PST 
Comment on attachment 389605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389605&action=review

r=me

> Source/bmalloc/bmalloc/BPlatform.h:286
> +#elif defined(__GNUC__)

Use `BCOMPILER(GCC_COMPATIBLE)` here.
Comment 5 Don Olmstead 2020-02-04 16:23:52 PST 
Created attachment 389736 [details]
Patch
Comment 6 WebKit Commit Bot 2020-02-05 10:37:47 PST 
Comment on attachment 389736 [details]
Patch

Clearing flags on attachment: 389736

Committed r255829: <https://trac.webkit.org/changeset/255829>
Comment 7 WebKit Commit Bot 2020-02-05 10:37:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-02-05 10:38:16 PST 
<rdar://problem/59193595>