Bug 207056 - [macOS] AirPlay sometimes stops after 60 minutes of playback
Summary: [macOS] AirPlay sometimes stops after 60 minutes of playback
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-31 10:25 PST by Eric Carlson
Modified: 2020-02-03 12:19 PST (History)
8 users (show)

See Also:

Attachments
Patch (27.81 KB, patch)
2020-01-31 11:08 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Updated patch. (4.51 MB, patch)
2020-01-31 13:46 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (27.80 KB, patch)
2020-02-03 08:48 PST, Eric Carlson 		jer.noble: review+
Details | Formatted Diff | Diff
Patch for landing. (28.12 KB, patch)
2020-02-03 09:51 PST, Eric Carlson 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing. (28.12 KB, patch)
2020-02-03 11:34 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2020-01-31 10:25:25 PST 
AirPlay sometimes stops after 60 minutes of playback

<rdar://problem/53649508>
Comment 1 Eric Carlson 2020-01-31 11:08:20 PST 
Created attachment 389381 [details]
Patch
Comment 2 Jon Lee 2020-01-31 11:39:59 PST 
Comment on attachment 389381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389381&action=review

> Source/WebCore/ChangeLog:15
> +        AirPlay can't actually be active is an item doesn't have audio or video, so always claim

if* an item

> Source/WebCore/ChangeLog:16
> +        to have both during AirPlay.

any side effects if the video has no audio tracks?
Comment 3 Eric Carlson 2020-01-31 13:45:59 PST 
Comment on attachment 389381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389381&action=review

>> Source/WebCore/ChangeLog:15
>> +        AirPlay can't actually be active is an item doesn't have audio or video, so always claim
> 
> if* an item

Oops!

>> Source/WebCore/ChangeLog:16
>> +        to have both during AirPlay.
> 
> any side effects if the video has no audio tracks?

No.
Comment 4 Eric Carlson 2020-01-31 13:46:35 PST 
Created attachment 389407 [details]
Updated patch.
Comment 5 Eric Carlson 2020-02-03 08:48:47 PST 
Created attachment 389519 [details]
Patch
Comment 6 Eric Carlson 2020-02-03 09:51:39 PST 
Created attachment 389531 [details]
Patch for landing.
Comment 7 WebKit Commit Bot 2020-02-03 10:26:46 PST 
Comment on attachment 389531 [details]
Patch for landing.

Rejecting attachment 389531 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 389531, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13316107
Comment 8 Eric Carlson 2020-02-03 11:34:58 PST 
Created attachment 389542 [details]
Patch for landing.
Comment 9 WebKit Commit Bot 2020-02-03 12:19:50 PST 
Comment on attachment 389542 [details]
Patch for landing.

Clearing flags on attachment: 389542

Committed r255581: <https://trac.webkit.org/changeset/255581>