Bug 207017 - Can still get stuck after swipe backwards with a slow server, even after r254552
Summary: Can still get stuck after swipe backwards with a slow server, even after r254552
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-30 14:07 PST by Tim Horton
Modified: 2020-01-30 14:31 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.35 KB, patch)
2020-01-30 14:07 PST, Tim Horton 		cdumez: review+
cdumez: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-01-30 14:07:21 PST 
Can still get stuck after swipe backwards with a slow server, even after r254552
Comment 1 Tim Horton 2020-01-30 14:07:31 PST 
Created attachment 389287 [details]
Patch
Comment 2 Tim Horton 2020-01-30 14:08:52 PST 
<rdar://problem/59016256>
Comment 3 Chris Dumez 2020-01-30 14:10:08 PST 
Comment on attachment 389287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389287&action=review

> Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:391
> +void ProvisionalPageProxy::navigationGestureDidEnd()

Can we call this something like: unfreezeLayerTreeDueToSwipeAnimation() ? Given that you're only calling this when the m_isLayerTreeFrozenDueToSwipeAnimation flag is set on the WebPageProxy.
Comment 4 Tim Horton 2020-01-30 14:28:45 PST 
Heh, that was the first name I had for it. Sure!
Comment 5 Tim Horton 2020-01-30 14:31:51 PST 
https://trac.webkit.org/changeset/255458/webkit