Bug 206966 - Don't include CCallHelpers.h in B3Procedure.h
Summary: Don't include CCallHelpers.h in B3Procedure.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-29 14:17 PST by Robin Morisset
Modified: 2020-01-29 15:36 PST (History)
8 users (show)

See Also:

Attachments
Patch (10.14 KB, patch)
2020-01-29 14:20 PST, Robin Morisset 		no flags Details | Formatted Diff | Diff
fix style nit (10.19 KB, patch)
2020-01-29 14:21 PST, Robin Morisset 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2020-01-29 14:17:30 PST 
It brings in AssemblyHelpers.h, which includes CodeBlock.h which brings basically the entire runtime.
There is no need for random B3 files to know about Heap.h or Structure.h or anything like that.
Comment 1 Robin Morisset 2020-01-29 14:20:31 PST 
Created attachment 389185 [details]
Patch
Comment 2 Robin Morisset 2020-01-29 14:21:46 PST 
Created attachment 389186 [details]
fix style nit
Comment 3 Saam Barati 2020-01-29 15:04:15 PST 
Comment on attachment 389186 [details]
fix style nit

View in context: https://bugs.webkit.org/attachment.cgi?id=389186&action=review

> Source/JavaScriptCore/b3/testb3_6.cpp:2176
> +    CodeLocationLabel<B3CompilationPtrTag> labelOne = linkBuffer.locationOf<B3CompilationPtrTag>(proc.code().entrypointLabel(0));

should we also make AirCode not use Label directly?
Comment 4 Saam Barati 2020-01-29 15:05:57 PST 
(In reply to Saam Barati from comment #3)
> Comment on attachment 389186 [details]
> fix style nit
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=389186&action=review
> 
> > Source/JavaScriptCore/b3/testb3_6.cpp:2176
> > +    CodeLocationLabel<B3CompilationPtrTag> labelOne = linkBuffer.locationOf<B3CompilationPtrTag>(proc.code().entrypointLabel(0));
> 
> should we also make AirCode not use Label directly?

We could also make Label not depend on AssemblerLabel/Masm since we only have one type per compilation target
Comment 5 WebKit Commit Bot 2020-01-29 15:35:38 PST 
Comment on attachment 389186 [details]
fix style nit

Clearing flags on attachment: 389186

Committed r255394: <https://trac.webkit.org/changeset/255394>
Comment 6 WebKit Commit Bot 2020-01-29 15:35:39 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-01-29 15:36:14 PST 
<rdar://problem/59009948>