Bug 206923 - Content blocker: ignore and report problematic rules instead of refusing to load the whole content blocker
Summary: Content blocker: ignore and report problematic rules instead of refusing to l...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-29 02:25 PST by Andrey Meshkov
Modified: 2020-02-19 00:17 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Meshkov 2020-01-29 02:25:31 PST
The problem with the current approach is that any invalid rule breaks the content blocker completely. Also, there's no way to learn what exact rule is invalid, we even had to come up with a script that uses some kind of a "binary search" algorithm to find problematic rules. Overall, this experience is really painful for people who are trying to create content blockers.

Here's what I suggest:

1. Ignore problematic rules instead of throwing out the whole content blocker.
2. Extend the setContentBlocker callback parameter and put a list with the problematic rules there.
Comment 1 Radar WebKit Bug Importer 2020-01-29 13:53:19 PST
<rdar://problem/59005370>