Bug 206851 - Remove the include of BytecodeGenerator.h in CodeCache.h
Summary: Remove the include of BytecodeGenerator.h in CodeCache.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks: 206720
  Show dependency tree / graph
 
Reported: 2020-01-27 16:30 PST by Robin Morisset
Modified: 2020-01-28 16:23 PST (History)
8 users (show)

See Also:

Attachments
Patch (21.51 KB, patch)
2020-01-27 16:39 PST, Robin Morisset 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2020-01-27 16:30:52 PST 
This is a blocker for https://bugs.webkit.org/show_bug.cgi?id=206720.
Even by itself, it should help for compile times, since BytecodeGenerator.h includes the huge BytecodeStructs.h and CodeCache.h is included in quite a few places.
Comment 1 Robin Morisset 2020-01-27 16:39:13 PST 
Created attachment 388936 [details]
Patch
Comment 2 Tadeu Zagallo 2020-01-27 16:53:16 PST 
Comment on attachment 388936 [details]
Patch

r=me
Comment 3 Mark Lam 2020-01-27 16:59:07 PST 
r=me too.
Comment 4 WebKit Commit Bot 2020-01-28 16:22:22 PST 
Comment on attachment 388936 [details]
Patch

Clearing flags on attachment: 388936

Committed r255321: <https://trac.webkit.org/changeset/255321>
Comment 5 WebKit Commit Bot 2020-01-28 16:22:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-01-28 16:23:13 PST 
<rdar://problem/58974442>