Bug 206838 - WebCore: Guard uneven corners in rounded rectangles
Summary: WebCore: Guard uneven corners in rounded rectangles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-27 13:03 PST by Jonathan Bedard
Modified: 2020-01-28 10:11 PST (History)
10 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2020-01-27 13:12 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (2.32 KB, patch)
2020-01-27 15:38 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2020-01-28 08:37 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-01-27 13:03:05 PST 
Per Darin's comments in https://bugs.webkit.org/show_bug.cgi?id=206096, we should add USE(CG_PATH_ADD_UNEVEN_CORNERS_ROUNDEDRECT)
Comment 1 Jonathan Bedard 2020-01-27 13:03:37 PST 
Not 100% certain this should be a USE macro, but it seems more fitting then a HAVE macro.
Comment 2 Jonathan Bedard 2020-01-27 13:12:25 PST 
Created attachment 388889 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-01-27 13:23:21 PST 
Comment on attachment 388889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388889&action=review

> Source/WTF/wtf/PlatformUse.h:312
> +#define USE_CG_PATH_ADD_UNEVEN_CORNERS_ROUNDEDRECT 1

I think this should be a HAVE_ in PlatformHave.h
Comment 4 Jonathan Bedard 2020-01-27 15:38:34 PST 
Created attachment 388928 [details]
Patch
Comment 5 Darin Adler 2020-01-27 16:40:48 PST 
Comment on attachment 388928 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388928&action=review

> Source/WTF/wtf/PlatformHave.h:569
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) || PLATFORM(MACCATALYST)

I think we might want to consider a slightly more forward-looking version of the check:

    #if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101400) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
Comment 6 Jonathan Bedard 2020-01-28 08:37:07 PST 
Created attachment 389002 [details]
Patch
Comment 7 WebKit Commit Bot 2020-01-28 10:10:55 PST 
Comment on attachment 389002 [details]
Patch

Clearing flags on attachment: 389002

Committed r255255: <https://trac.webkit.org/changeset/255255>
Comment 8 WebKit Commit Bot 2020-01-28 10:10:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-01-28 10:11:12 PST 
<rdar://problem/58959405>