Bug 206764 - Content filter should use WTF::Function instead of std::function
Summary: Content filter should use WTF::Function instead of std::function
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-24 12:25 PST by Alex Christensen
Modified: 2020-06-12 20:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (13.22 KB, patch)
2020-01-24 13:19 PST, Alex Christensen 		ysuzuki: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-01-24 12:25:29 PST 
Content filter should use async completion handler instead of ignoring then reloading
Comment 1 Alex Christensen 2020-01-24 13:19:00 PST 
Created attachment 388720 [details]
Patch
Comment 2 Alex Christensen 2020-01-24 14:11:43 PST 
Andy, any idea what I did wrong in this first patch?
Comment 3 youenn fablet 2020-01-30 00:20:36 PST 
Comment on attachment 388720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388720&action=review

> Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:78
> +        wrapped.requestUnblockAsync([wrappedDecisionHandler = WTFMove(wrappedDecisionHandler), decisionHandler = WTFMove(decisionHandler)](bool unblocked) mutable {

Can m_unblockRequester be called multiple times?
If so, we are moving decisionHandler several times.
Should we instead have decisionHandler be part of ContentFilterUnblockHandler?

> Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:377
> +void ProvisionalPageProxy::contentFilterDidBlockLoadForFrame(WebCore::ContentFilterUnblockHandler&& unblockHandler, FrameIdentifier frameID)

s/WebCore::/

> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:104
> +void WebPageProxy::contentFilterDidBlockLoadForFrame(WebCore::ContentFilterUnblockHandler&& unblockHandler, FrameIdentifier frameID)

s/WebCore::/

> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:109
> +void WebPageProxy::contentFilterDidBlockLoadForFrameShared(Ref<WebProcessProxy>&& process, WebCore::ContentFilterUnblockHandler&& unblockHandler, FrameIdentifier frameID)

s/WebCore::/
Also, why are we passing a Ref<WebProcessProxy>&&? Can we use a WebProcessProxy& instead?

> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:111
>      if (WebFrameProxy* frame = process->webFrame(frameID))

auto*
Comment 4 Yusuke Suzuki 2020-06-12 20:38:25 PDT 
Comment on attachment 388720 [details]
Patch

Putting r- since it is already reviewed and need some changes.