Bug 206716 - macCatalyst: I-Beam is too conservative, doesn't show up in editable areas with no text
Summary: macCatalyst: I-Beam is too conservative, doesn't show up in editable areas wi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-23 16:38 PST by Tim Horton
Modified: 2020-01-23 18:22 PST (History)
7 users (show)

See Also:

Attachments
Patch (7.26 KB, patch)
2020-01-23 16:38 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (7.31 KB, patch)
2020-01-23 18:11 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-01-23 16:38:00 PST 
macCatalyst: I-Beam is too conservative, doesn't show up in editable areas with no text
Comment 1 Tim Horton 2020-01-23 16:38:24 PST 
Created attachment 388615 [details]
Patch
Comment 2 Tim Horton 2020-01-23 16:38:25 PST 
<rdar://problem/58359523>
Comment 3 zalan 2020-01-23 17:59:44 PST 
Comment on attachment 388615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388615&action=review

> Source/WebCore/editing/VisiblePosition.cpp:675
> +    Node* node = m_deepPosition.anchorNode();

auto*

> Source/WebCore/editing/VisiblePosition.cpp:679
> +    InlineBox* inlineBox;

nullptr it please

> Source/WebCore/editing/VisiblePosition.cpp:680
> +    int caretOffset;

this should have an initial value too

> Source/WebCore/editing/VisiblePosition.cpp:687
> +    FloatRect localRect(root.x(), root.selectionTop(), root.width(), root.selectionHeight());

isn't "auto localRect = FloatRect { }" the preferred way by now?
Comment 4 zalan 2020-01-23 18:03:38 PST 
Comment on attachment 388615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388615&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2759
> +    auto renderer = hitTestResult.innerNode()->renderer();

auto*
Comment 5 Tim Horton 2020-01-23 18:11:15 PST 
Created attachment 388633 [details]
Patch
Comment 6 Tim Horton 2020-01-23 18:22:26 PST 
https://trac.webkit.org/changeset/255046/webkit