Bug 206706 - Get rid of didFinishParsing and make parseInner return its results
Summary: Get rid of didFinishParsing and make parseInner return its results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 197106
  Show dependency tree / graph
 
Reported: 2020-01-23 15:34 PST by Saam Barati
Modified: 2020-01-24 11:12 PST (History)
14 users (show)

See Also:

Attachments
patch (10.94 KB, patch)
2020-01-23 17:26 PST, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (10.97 KB, patch)
2020-01-23 18:09 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-01-23 15:34:42 PST 
Cleans up some code and makes parseInner less stateful. This should make it easier to eagerly parse IIFE
Comment 1 Saam Barati 2020-01-23 17:26:43 PST 
Created attachment 388626 [details]
patch
Comment 2 Mark Lam 2020-01-23 17:31:08 PST 
Comment on attachment 388626 [details]
patch

r=me
Comment 3 Keith Miller 2020-01-23 17:31:19 PST 
Comment on attachment 388626 [details]
patch

r=me.
Comment 4 Yusuke Suzuki 2020-01-23 17:31:24 PST 
Comment on attachment 388626 [details]
patch

r=me too, nice. didFinishParsing looks ugly.
Comment 5 Saam Barati 2020-01-23 18:09:48 PST 
Created attachment 388632 [details]
patch for landing
Comment 6 WebKit Commit Bot 2020-01-23 18:54:42 PST 
Comment on attachment 388632 [details]
patch for landing

Clearing flags on attachment: 388632

Committed r255047: <https://trac.webkit.org/changeset/255047>
Comment 7 WebKit Commit Bot 2020-01-23 18:54:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-01-23 18:55:14 PST 
<rdar://problem/58857211>
Comment 9 Yusuke Suzuki 2020-01-23 21:42:01 PST 
Committed r255053: <https://trac.webkit.org/changeset/255053>
Comment 10 Saam Barati 2020-01-24 11:12:16 PST 
(In reply to Yusuke Suzuki from comment #9)
> Committed r255053: <https://trac.webkit.org/changeset/255053>

oops. Thanks for fixing