Bug 206675 - REGRESSION: [Mac wk2] fast/animation/request-animation-frame.html is flaky failing
Summary: REGRESSION: [Mac wk2] fast/animation/request-animation-frame.html is flaky fa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-23 10:22 PST by Jacob Uphoff
Modified: 2020-01-27 10:39 PST (History)
9 users (show)

See Also:

Attachments
Patch (3.11 KB, patch)
2020-01-27 08:49 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.11 KB, patch)
2020-01-27 09:41 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacob Uphoff 2020-01-23 10:22:06 PST 
fast/animation/request-animation-frame.html is flaky failing on Mojave wk2 starting around commit 254128

I did not try to reproduce

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fanimation%2Frequest-animation-frame.html

Diff:

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/animation/request-animation-frame-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/animation/request-animation-frame-actual.txt
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS callbackInvoked is true
+FAIL callbackInvoked should be true. Was false.
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Truitt Savell 2020-01-23 10:41:52 PST 
This looks like it was fixed for a time around 254405 then broke again around 254790
Comment 2 Radar WebKit Bug Importer 2020-01-23 10:41:53 PST 
<rdar://problem/58839955>
Comment 3 Chris Dumez 2020-01-27 08:49:59 PST 
Created attachment 388864 [details]
Patch
Comment 4 Said Abou-Hallawa 2020-01-27 08:59:42 PST 
Comment on attachment 388864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388864&action=review

> LayoutTests/fast/animation/request-animation-frame.html:8
>  <span id="e"></span>
>  <span id="f"></span>

Do we still need these two elements?
Comment 5 Chris Dumez 2020-01-27 09:41:19 PST 
(In reply to Said Abou-Hallawa from comment #4)
> Comment on attachment 388864 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388864&action=review
> 
> > LayoutTests/fast/animation/request-animation-frame.html:8
> >  <span id="e"></span>
> >  <span id="f"></span>
> 
> Do we still need these two elements?

No, will drop' em
Comment 6 Chris Dumez 2020-01-27 09:41:34 PST 
Created attachment 388868 [details]
Patch
Comment 7 WebKit Commit Bot 2020-01-27 10:39:05 PST 
Comment on attachment 388868 [details]
Patch

Clearing flags on attachment: 388868

Committed r255153: <https://trac.webkit.org/changeset/255153>
Comment 8 WebKit Commit Bot 2020-01-27 10:39:07 PST 
All reviewed patches have been landed.  Closing bug.