Bug 206608 - REGRESSION (r253519): [WKWebView evaluateJavaScript:completionHandler:] gives a non-nil, non-Error result even when JavaScript cannot be evaluated
Summary: REGRESSION (r253519): [WKWebView evaluateJavaScript:completionHandler:] gives...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-22 12:24 PST by Brady Eidson
Modified: 2020-01-22 15:48 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.41 KB, patch)
2020-01-22 12:39 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2020-01-22 12:24:49 PST 
REGRESSION (r253519): [WKWebView evaluateJavaScript:completionHandler:] gives a non-nil, non-Error result even when JavaScript cannot be evaluated

<rdar://problem/58544942>
Comment 1 Brady Eidson 2020-01-22 12:39:49 PST 
Created attachment 388459 [details]
Patch
Comment 2 Alex Christensen 2020-01-22 13:00:37 PST 
Comment on attachment 388459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388459&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:235
> +    TCPServer server([](int socket) {

You could've used HTTPServer since this only adds headers fields and body, but this is fine too.
Comment 3 WebKit Commit Bot 2020-01-22 15:48:35 PST 
Comment on attachment 388459 [details]
Patch

Clearing flags on attachment: 388459

Committed r254950: <https://trac.webkit.org/changeset/254950>
Comment 4 WebKit Commit Bot 2020-01-22 15:48:36 PST 
All reviewed patches have been landed.  Closing bug.