Bug 206551 - [iOS] Make it possible for WebKit clients to enable connections to asset services in the WebContent process
Summary: [iOS] Make it possible for WebKit clients to enable connections to asset serv...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-21 13:05 PST by Per Arne Vollan
Modified: 2020-01-23 14:21 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.45 KB, patch)
2020-01-21 13:16 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (8.45 KB, patch)
2020-01-21 16:17 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (8.45 KB, patch)
2020-01-21 16:30 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (8.44 KB, patch)
2020-01-21 17:13 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (8.67 KB, patch)
2020-01-21 19:57 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (8.73 KB, patch)
2020-01-22 10:40 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (8.67 KB, patch)
2020-01-22 11:00 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (8.68 KB, patch)
2020-01-22 11:10 PST, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch (8.69 KB, patch)
2020-01-22 12:42 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (8.72 KB, patch)
2020-01-23 13:01 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-01-21 13:05:22 PST 
Some apps needs the WebContent process to be able to access asset services. In these cases, sandbox extensions should be created in the UI process and sent to the WebContent process.
Comment 1 Per Arne Vollan 2020-01-21 13:16:04 PST 
Created attachment 388340 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-01-21 13:16:36 PST 
<rdar://problem/58770894>
Comment 3 Per Arne Vollan 2020-01-21 16:17:13 PST 
Created attachment 388365 [details]
Patch
Comment 4 Per Arne Vollan 2020-01-21 16:30:39 PST 
Created attachment 388371 [details]
Patch
Comment 5 Per Arne Vollan 2020-01-21 17:13:38 PST 
Created attachment 388379 [details]
Patch
Comment 6 Per Arne Vollan 2020-01-21 19:57:59 PST 
Created attachment 388393 [details]
Patch
Comment 7 Per Arne Vollan 2020-01-22 10:40:20 PST 
Created attachment 388438 [details]
Patch
Comment 8 Per Arne Vollan 2020-01-22 11:00:33 PST 
Created attachment 388441 [details]
Patch
Comment 9 Per Arne Vollan 2020-01-22 11:10:39 PST 
Created attachment 388443 [details]
Patch
Comment 10 Brent Fulgham 2020-01-22 11:51:24 PST 
Comment on attachment 388443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388443&action=review

Looks good! r=me

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:491
> +- (void)_revokeAccessToAssetServices WK_API_AVAILABLE(ios(14.0));

Should these be WK_TBA?
Comment 11 Per Arne Vollan 2020-01-22 12:42:56 PST 
Created attachment 388460 [details]
Patch
Comment 12 Per Arne Vollan 2020-01-22 12:43:44 PST 
(In reply to Brent Fulgham from comment #10)
> Comment on attachment 388443 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388443&action=review
> 
> Looks good! r=me
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:491
> > +- (void)_revokeAccessToAssetServices WK_API_AVAILABLE(ios(14.0));
> 
> Should these be WK_TBA?

Fixed.

Thanks for reviewing!
Comment 13 WebKit Commit Bot 2020-01-23 11:09:08 PST 
Comment on attachment 388460 [details]
Patch

Clearing flags on attachment: 388460

Committed r254990: <https://trac.webkit.org/changeset/254990>
Comment 14 Ryan Haddad 2020-01-23 11:56:43 PST 
Reverted r254990 for reason:

Breaks watchOS / tvOS builds.

Committed r254994: <https://trac.webkit.org/changeset/254994>
Comment 15 Per Arne Vollan 2020-01-23 13:01:23 PST 
Created attachment 388583 [details]
Patch
Comment 16 WebKit Commit Bot 2020-01-23 14:13:59 PST 
Comment on attachment 388583 [details]
Patch

Clearing flags on attachment: 388583

Committed r255038: <https://trac.webkit.org/changeset/255038>