Bug 206541 - Remove ImageBuffer::sizeForDestinationSize()
Summary: Remove ImageBuffer::sizeForDestinationSize()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: DoNotImportToRadar
Depends on: 206519
Blocks: 204955
  Show dependency tree / graph
 
Reported: 2020-01-21 10:11 PST by Said Abou-Hallawa
Modified: 2020-01-22 16:00 PST (History)
30 users (show)

See Also:

Attachments
Patch (86.96 KB, patch)
2020-01-21 10:15 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (85.89 KB, patch)
2020-01-21 13:48 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (18.14 KB, patch)
2020-01-22 00:18 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (17.00 KB, patch)
2020-01-22 12:20 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2020-01-21 10:11:29 PST 
This function is currently does nothing. For CG ports, it scales a rect by the ratio backingStoreSize / internalSize which is always 1. The constructor ImageBuffer::ImageBuffer() sets m_size and m_data.backingStoreSize to the same value always.

    m_size = IntSize(scaledWidth, scaledHeight);
    m_data.backingStoreSize = m_size;

For other ports ImageBuffer::sizeForDestinationSize() returns the passed rectangle.
Comment 1 Said Abou-Hallawa 2020-01-21 10:15:32 PST 
Created attachment 388315 [details]
Patch
Comment 2 Said Abou-Hallawa 2020-01-21 13:48:12 PST 
Created attachment 388342 [details]
Patch
Comment 3 Said Abou-Hallawa 2020-01-22 00:18:03 PST 
Created attachment 388402 [details]
Patch
Comment 4 Said Abou-Hallawa 2020-01-22 12:20:42 PST 
Created attachment 388457 [details]
Patch
Comment 5 WebKit Commit Bot 2020-01-22 13:31:43 PST 
The commit-queue encountered the following flaky tests while processing attachment 388457 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-01-22 13:32:16 PST 
Comment on attachment 388457 [details]
Patch

Clearing flags on attachment: 388457

Committed r254941: <https://trac.webkit.org/changeset/254941>
Comment 7 WebKit Commit Bot 2020-01-22 13:32:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-01-22 15:58:33 PST 
<rdar://problem/58814730>