Bug 206507 - [LFC][IFC] InlineFormattingContext::lineLayout should take a InlineItem range
Summary: [LFC][IFC] InlineFormattingContext::lineLayout should take a InlineItem range
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-20 11:49 PST by zalan
Modified: 2020-01-20 15:32 PST (History)
6 users (show)

See Also:

Attachments
Patch (20.05 KB, patch)
2020-01-20 12:18 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (21.90 KB, patch)
2020-01-20 12:55 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-01-20 11:49:19 PST 
instead of going from 0 to InlineItemList.size()
Comment 1 Radar WebKit Bug Importer 2020-01-20 11:49:55 PST 
<rdar://problem/58742468>
Comment 2 zalan 2020-01-20 12:18:46 PST 
Created attachment 388249 [details]
Patch
Comment 3 Antti Koivisto 2020-01-20 12:20:39 PST 
Comment on attachment 388249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388249&action=review

> Source/WebCore/layout/inlineformatting/LineLayoutContext.h:54
> +        bool isEmpty() const { return start >= end; }

Why would start > end?
Comment 4 zalan 2020-01-20 12:37:35 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 388249 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388249&action=review
> 
> > Source/WebCore/layout/inlineformatting/LineLayoutContext.h:54
> > +        bool isEmpty() const { return start >= end; }
> 
> Why would start > end?
indeed why would.
Comment 5 zalan 2020-01-20 12:55:59 PST 
Created attachment 388251 [details]
Patch
Comment 6 WebKit Commit Bot 2020-01-20 15:32:56 PST 
Comment on attachment 388251 [details]
Patch

Clearing flags on attachment: 388251

Committed r254837: <https://trac.webkit.org/changeset/254837>
Comment 7 WebKit Commit Bot 2020-01-20 15:32:57 PST 
All reviewed patches have been landed.  Closing bug.