Bug 206468 - [Media in GPU process] Pipe more MediaPlayerPrivate and client methods
Summary: [Media in GPU process] Pipe more MediaPlayerPrivate and client methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-17 23:58 PST by Jon Lee
Modified: 2020-01-22 22:32 PST (History)
13 users (show)

See Also:

Attachments
Patch (19.54 KB, patch)
2020-01-18 00:25 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
Patch (20.32 KB, patch)
2020-01-18 16:50 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
Patch (22.46 KB, patch)
2020-01-22 15:13 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
Patch (22.44 KB, patch)
2020-01-22 16:13 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2020-01-17 23:58:31 PST 
Pipe more MediaPlayerPrivate and client methods
Comment 1 Jon Lee 2020-01-18 00:25:44 PST 
Created attachment 388136 [details]
Patch
Comment 2 Eric Carlson 2020-01-18 10:02:02 PST 
Comment on attachment 388136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388136&action=review

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:476
> +    m_webProcessConnection->send(Messages::RemoteMediaPlayerManager::CurrentPlaybackTargetIsWirelessChanged(m_id), 0);

HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged immediately calls m_player->isCurrentPlaybackTargetWireless(), so we should push that state here and cache it in the MediaPlayerPrivateRemote.

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:684
> +    if (m_player)

m_player is never NULL.

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:942
> +    if (m_player)

Ditto.

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:948
> +    if (m_player)

Ditto.

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:954
> +    if (m_player)

Ditto.
Comment 3 Jon Lee 2020-01-18 16:50:30 PST 
Created attachment 388162 [details]
Patch
Comment 4 Eric Carlson 2020-01-18 17:31:48 PST 
Comment on attachment 388162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388162&action=review

Thanks!

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:815
> +    if (m_player)

This test is unnecessary.
Comment 5 Jon Lee 2020-01-19 21:32:58 PST 
Comment on attachment 388162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388162&action=review

>> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:815
>> +    if (m_player)
> 
> This test is unnecessary.

Whoops, will remove.
Comment 6 Jon Lee 2020-01-22 15:13:25 PST 
Created attachment 388474 [details]
Patch
Comment 7 Eric Carlson 2020-01-22 15:20:18 PST 
Comment on attachment 388474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388474&action=review

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:815
> +    if (m_player)

:-/
Comment 8 Jon Lee 2020-01-22 16:13:03 PST 
Created attachment 388481 [details]
Patch
Comment 9 WebKit Commit Bot 2020-01-22 22:31:39 PST 
Comment on attachment 388481 [details]
Patch

Clearing flags on attachment: 388481

Committed r254964: <https://trac.webkit.org/changeset/254964>
Comment 10 WebKit Commit Bot 2020-01-22 22:31:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2020-01-22 22:32:13 PST 
<rdar://problem/58825046>