Bug 206461 - JSModuleLoader's printableModuleKey() should never throw.
Summary: JSModuleLoader's printableModuleKey() should never throw.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
: 206414 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-01-17 16:49 PST by Mark Lam
Modified: 2020-01-20 02:09 PST (History)
7 users (show)

See Also:

Attachments
proposed patch. (2.39 KB, patch)
2020-01-17 16:55 PST, Mark Lam 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-01-17 16:49:00 PST 
Hence, it should be using a CatchScope instead of a ThrowScope.

<rdar://problem/58696678>
Comment 1 Mark Lam 2020-01-17 16:55:14 PST 
Created attachment 388117 [details]
proposed patch.
Comment 2 Michael Saboff 2020-01-17 16:58:56 PST 
Comment on attachment 388117 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2020-01-17 17:03:05 PST 
Thanks for the review.  Landed in r254783: <http://trac.webkit.org/r254783>.
Comment 4 Caio Lima 2020-01-20 02:09:35 PST 
*** Bug 206414 has been marked as a duplicate of this bug. ***