Bug 206435 - Fix tvOS values in SUPPORTED_PLATFORMS
Summary: Fix tvOS values in SUPPORTED_PLATFORMS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-17 12:40 PST by Keith Rollin
Modified: 2020-01-21 11:40 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.62 KB, patch)
2020-01-17 12:42 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-01-17 12:40:17 PST 
A number of targets in WebKit have 'tvos' and 'tvsimulator' in SUPPORTED_PLATFORMS. The correct values are 'appletvos' and 'appletvsimulator'. These should be updated to the correct ones as the wrong values prevent the tvOS run destination from being usable in the UI to build for tvOS.
Comment 1 Keith Rollin 2020-01-17 12:40:42 PST 
<rdar://problem/58674587>
Comment 2 Keith Rollin 2020-01-17 12:42:45 PST 
Created attachment 388076 [details]
Patch
Comment 3 Alexey Proskuryakov 2020-01-17 12:50:09 PST 
Comment on attachment 388076 [details]
Patch

Seems fine. Please don't land before the long weekend.
Comment 4 Keith Rollin 2020-01-17 12:58:20 PST 
Alright.
Comment 5 WebKit Commit Bot 2020-01-21 11:40:52 PST 
Comment on attachment 388076 [details]
Patch

Clearing flags on attachment: 388076

Committed r254868: <https://trac.webkit.org/changeset/254868>
Comment 6 WebKit Commit Bot 2020-01-21 11:40:54 PST 
All reviewed patches have been landed.  Closing bug.