Bug 206413 - ASSERT in case a service worker cannot be terminated in a timely manner
Summary: ASSERT in case a service worker cannot be terminated in a timely manner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-17 07:29 PST by youenn fablet
Modified: 2020-01-22 14:19 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2020-01-17 07:36 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-01-17 07:29:41 PST 
ASSERT in case a service worker cannot be terminated in a timely manner.
This might help debugging test flakiness.
Comment 1 youenn fablet 2020-01-17 07:36:09 PST 
Created attachment 388038 [details]
Patch
Comment 2 Alexey Proskuryakov 2020-01-17 23:24:55 PST 
Comment on attachment 388038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388038&action=review

> Source/WebCore/workers/service/context/SWContextManager.cpp:168
> +    ASSERT_NOT_REACHED();
>      _exit(EXIT_FAILURE);

Builds passed on EWS, but I recall some ports failing to build because of unreachable code warnings in the past. Maybe they disabled the warning.
Comment 3 youenn fablet 2020-01-20 00:18:29 PST 
(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 388038 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388038&action=review
> 
> > Source/WebCore/workers/service/context/SWContextManager.cpp:168
> > +    ASSERT_NOT_REACHED();
> >      _exit(EXIT_FAILURE);
> 
> Builds passed on EWS, but I recall some ports failing to build because of
> unreachable code warnings in the past. Maybe they disabled the warning.

I remember hitting that issue on EWS. Either it has changed or the call to exit changes things?
Comment 4 youenn fablet 2020-01-20 00:18:56 PST 
Will land it as is and will check webkit console.
Comment 5 WebKit Commit Bot 2020-01-20 01:02:44 PST 
Comment on attachment 388038 [details]
Patch

Clearing flags on attachment: 388038

Committed r254812: <https://trac.webkit.org/changeset/254812>
Comment 6 WebKit Commit Bot 2020-01-20 01:02:45 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-01-20 01:03:15 PST 
<rdar://problem/58732681>
Comment 8 Alexey Proskuryakov 2020-01-22 14:19:44 PST 
We are not hitting this assertion on tests where ServiceWorker process terminates unexpectedly.