Bug 206404 - Bytecode checkpoints break 32bit tests
Summary: Bytecode checkpoints break 32bit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-17 00:44 PST by Paulo Matos
Modified: 2020-01-17 08:36 PST (History)
9 users (show)

See Also:

Attachments
Patch (1.19 KB, patch)
2020-01-17 04:10 PST, Caio Lima 		no flags Details | Formatted Diff | Diff
Patch (1.30 KB, patch)
2020-01-17 07:26 PST, Caio Lima 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paulo Matos 2020-01-17 00:44:46 PST 
The reland of the bytecode checkpoints (https://bugs.webkit.org/show_bug.cgi?id=206361) break 32bit tests:
https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/builds/10571
Comment 1 Paulo Matos 2020-01-17 00:51:18 PST 
Failure in debug mode looks like:
stress/plus-boolean-or-int.js.mini-mode: ASSERTION FAILED: returnAddress >= instructionsBegin && returnAddress < instructionsEnd
stress/plus-boolean-or-int.js.mini-mode: ../../Source/JavaScriptCore/bytecode/CodeBlock.h(394) : unsigned int JSC::CodeBlock::bytecodeOffset(const JSC::Instruction*)
stress/plus-boolean-or-int.js.mini-mode: Aborted
stress/plus-boolean-or-int.js.mini-mode: ERROR: Unexpected exit code: 134
Comment 2 Caio Lima 2020-01-17 04:10:25 PST 
Created attachment 388027 [details]
Patch
Comment 3 Caio Lima 2020-01-17 07:26:54 PST 
Created attachment 388036 [details]
Patch
Comment 4 WebKit Commit Bot 2020-01-17 08:14:27 PST 
Comment on attachment 388036 [details]
Patch

Clearing flags on attachment: 388036

Committed r254748: <https://trac.webkit.org/changeset/254748>
Comment 5 WebKit Commit Bot 2020-01-17 08:14:29 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-01-17 08:15:17 PST 
<rdar://problem/58682741>
Comment 7 Keith Miller 2020-01-17 08:36:16 PST 
Comment on attachment 388036 [details]
Patch

Whoops, thanks.