Bug 206386 - [iOS] Add telemetry for IOKIt classes not seen in test runs
Summary: [iOS] Add telemetry for IOKIt classes not seen in test runs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-16 16:37 PST by Brent Fulgham
Modified: 2020-01-16 19:55 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.76 KB, patch)
2020-01-16 16:39 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-01-16 16:37:10 PST 
Add telemetry to our uses of 'iokit-open' so we can see which classes are actively used by WebKit. Local test runs indicate many of these are not needed, but we need to capture wider data before changing our allow list.
Comment 1 Radar WebKit Bug Importer 2020-01-16 16:37:30 PST 
<rdar://problem/58663519>
Comment 2 Brent Fulgham 2020-01-16 16:39:16 PST 
Created attachment 387984 [details]
Patch
Comment 3 Per Arne Vollan 2020-01-16 16:43:55 PST 
Comment on attachment 387984 [details]
Patch

Looks good! R=me.
Comment 4 Brent Fulgham 2020-01-16 19:12:10 PST 
The Windows build failure is due to out-of-disk-space.
Comment 5 WebKit Commit Bot 2020-01-16 19:55:09 PST 
Comment on attachment 387984 [details]
Patch

Clearing flags on attachment: 387984

Committed r254734: <https://trac.webkit.org/changeset/254734>
Comment 6 WebKit Commit Bot 2020-01-16 19:55:11 PST 
All reviewed patches have been landed.  Closing bug.