Bug 206372 - [LFC][IFC] Optimize LineLayoutContext::tryAddingInlineItems for the most common inline content
Summary: [LFC][IFC] Optimize LineLayoutContext::tryAddingInlineItems for the most comm...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-16 14:15 PST by zalan
Modified: 2020-01-16 20:52 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.76 KB, patch)
2020-01-16 14:17 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.74 KB, patch)
2020-01-16 19:04 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-01-16 14:15:31 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2020-01-16 14:15:47 PST 
<rdar://problem/58657525>
Comment 2 zalan 2020-01-16 14:17:56 PST 
Created attachment 387958 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-01-16 14:21:58 PST 
Comment on attachment 387958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387958&action=review

> Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:209
> +inline void LineCandidateContent::reset()

Does the inlining actually make a difference?
Comment 4 zalan 2020-01-16 15:56:16 PST 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 387958 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387958&action=review
> 
> > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:209
> > +inline void LineCandidateContent::reset()
> 
> Does the inlining actually make a difference?
yes, this is a very hot codepath (I wouldn't have made this change otherwise)
Comment 5 zalan 2020-01-16 19:04:05 PST 
Created attachment 388002 [details]
Patch
Comment 6 WebKit Commit Bot 2020-01-16 20:52:10 PST 
Comment on attachment 388002 [details]
Patch

Clearing flags on attachment: 388002

Committed r254736: <https://trac.webkit.org/changeset/254736>
Comment 7 WebKit Commit Bot 2020-01-16 20:52:11 PST 
All reviewed patches have been landed.  Closing bug.