Bug 206357 - REGRESSION: ( r 254668 ) [ Mac Debug wk2 ] 21 http/tests/navigation/* tests are crashing with ASSERTION FAILED: world.first != 1
Summary: REGRESSION: ( r 254668 ) [ Mac Debug wk2 ] 21 http/tests/navigation/* tests a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-16 08:11 PST by Truitt Savell
Modified: 2020-01-16 11:17 PST (History)
4 users (show)

See Also:

Attachments
Patch (14.00 KB, patch)
2020-01-16 10:15 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (11.02 KB, patch)
2020-01-16 10:25 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2020-01-16 08:11:24 PST 
21 http/tests/navigation/* tests are crashing with ASSERTION FAILED: world.first != 1

Description:
It looks like the changes in https://trac.webkit.org/changeset/254668/webkit have caused Assertion crashes on these tests

results:
https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/r254668%20(1726)/results.html

Build:
https://build.webkit.org/builders/Apple-Catalina-Debug-WK2-Tests/builds/1726

example:
ASSERTION FAILED: world.first != 1
/Volumes/Data/slave/catalina-debug/build/Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp(106) : void WebKit::WebUserContentController::addUserContentWorld(const std::pair<uint64_t, String> &)
1   0x1e5e6fa79 WTFCrash
2   0x1c00020db WTFCrashWithInfo(int, char const*, char const*, int)
3   0x1c133dd02 WebKit::WebUserContentController::addUserContentWorld(std::__1::pair<unsigned long long, WTF::String> const&)
Comment 1 Radar WebKit Bug Importer 2020-01-16 08:11:47 PST 
<rdar://problem/58644525>
Comment 2 Brady Eidson 2020-01-16 09:02:13 PST 
Have a debug build locally, seeing if I can repro
Comment 3 Brady Eidson 2020-01-16 10:02:28 PST 
Easy repro, easy fix.
Comment 4 Brady Eidson 2020-01-16 10:15:49 PST 
Created attachment 387930 [details]
Patch
Comment 5 Brady Eidson 2020-01-16 10:25:52 PST 
Created attachment 387931 [details]
Patch
Comment 6 WebKit Commit Bot 2020-01-16 11:17:52 PST 
Comment on attachment 387931 [details]
Patch

Clearing flags on attachment: 387931

Committed r254698: <https://trac.webkit.org/changeset/254698>
Comment 7 WebKit Commit Bot 2020-01-16 11:17:54 PST 
All reviewed patches have been landed.  Closing bug.