Bug 206298 - Add more mousewheel-scrolling logging and improve the latching code
Summary: Add more mousewheel-scrolling logging and improve the latching code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-15 10:55 PST by Simon Fraser (smfr)
Modified: 2020-01-15 14:48 PST (History)
12 users (show)

See Also:

Attachments
Patch (17.91 KB, patch)
2020-01-15 10:56 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-01-15 10:55:04 PST 
Add more mousewheel-scrolling logging and improve the latching code
Comment 1 Simon Fraser (smfr) 2020-01-15 10:56:33 PST 
Created attachment 387804 [details]
Patch
Comment 2 WebKit Commit Bot 2020-01-15 13:23:01 PST 
Comment on attachment 387804 [details]
Patch

Clearing flags on attachment: 387804

Committed r254631: <https://trac.webkit.org/changeset/254631>
Comment 3 WebKit Commit Bot 2020-01-15 13:23:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-01-15 13:24:15 PST 
<rdar://problem/58616914>
Comment 5 Darin Adler 2020-01-15 13:25:35 PST 
Comment on attachment 387804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387804&action=review

> Source/WebCore/platform/PlatformWheelEvent.h:41
> +#if ENABLE(KINETIC_SCROLLING)
> +namespace WTF {
> +class TextStream;
> +}
> +#endif

This is inside an #if.

> Source/WebCore/platform/PlatformWheelEvent.h:242
> +WTF::TextStream& operator<<(WTF::TextStream&, const PlatformWheelEvent&);

This is not. One of these must be a mistake?
Comment 6 Simon Fraser (smfr) 2020-01-15 13:35:25 PST 
You're right, will fix.
Comment 7 Simon Fraser (smfr) 2020-01-15 14:48:49 PST 
https://trac.webkit.org/changeset/254640/webkit