Bug 206272 - Platform.h is out of control Part 4: Split PLATFORM_* macro definitions out of Platform.h and into a new PlatformLegacy.h
Summary: Platform.h is out of control Part 4: Split PLATFORM_* macro definitions out o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-14 19:04 PST by Sam Weinig
Modified: 2020-01-17 08:54 PST (History)
12 users (show)

See Also:

Attachments
Patch (69.20 KB, patch)
2020-01-14 19:05 PST, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-01-14 19:04:49 PST 
Platform.h is out of control Part 4: Split PLATFORM_* macro definitions out of Platform.h and into a new PlatformLegacy.h
Comment 1 Sam Weinig 2020-01-14 19:05:50 PST 
Created attachment 387745 [details]
Patch
Comment 2 Sam Weinig 2020-01-15 09:48:52 PST 
Committed r254572: <https://trac.webkit.org/changeset/254572>
Comment 3 Radar WebKit Bug Importer 2020-01-15 09:49:16 PST 
<rdar://problem/58608497>
Comment 4 Saam Barati 2020-01-16 00:34:31 PST 
Comment on attachment 387745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387745&action=review

> Source/WTF/ChangeLog:8
> +        As a another step towards cleaning up Platform.h, split out all the legacy platform

What makes these legacy?
Comment 5 Sam Weinig 2020-01-17 08:54:18 PST 
(In reply to Saam Barati from comment #4)
> Comment on attachment 387745 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387745&action=review
> 
> > Source/WTF/ChangeLog:8
> > +        As a another step towards cleaning up Platform.h, split out all the legacy platform
> 
> What makes these legacy?

There has been a long stated though poorly communicated goal of phasing out the use of PLATFORM() macros in favor of the more targeted ones. The comment above the definition has read for quite a while:

/* ==== PLATFORM handles OS, operating environment, graphics API, and
   CPU. This macro will be phased out in favor of platform adaptation
   macros, policy decision macros, and top-level port definitions. ==== */