Bug 206267 - Share WebInspector stubs for ports without local inspection
Summary: Share WebInspector stubs for ports without local inspection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks: 205965
  Show dependency tree / graph
 
Reported: 2020-01-14 16:40 PST by Don Olmstead
Modified: 2020-01-15 12:20 PST (History)
7 users (show)

See Also:

Attachments
Patch (14.65 KB, patch)
2020-01-14 16:46 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (14.40 KB, patch)
2020-01-14 16:49 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (15.03 KB, patch)
2020-01-14 17:35 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-01-14 16:40:26 PST 
For ports without a local inspector meaning you can't open a web inspector directly there are stubs that can be shared.
Comment 1 Don Olmstead 2020-01-14 16:46:21 PST Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-01-14 16:49:21 PST Comment hidden (obsolete)
Comment 3 Don Olmstead 2020-01-14 17:35:36 PST 
Created attachment 387742 [details]
Patch
Comment 4 Don Olmstead 2020-01-14 18:01:49 PST 
There's a bunch of stuff under Mac directories that isn't necessarily guarded by PLATFORM(MAC) and is still in SourcesCocoa.txt but overall I think this should be fine with iOS.
Comment 5 WebKit Commit Bot 2020-01-15 12:19:02 PST 
Comment on attachment 387742 [details]
Patch

Clearing flags on attachment: 387742

Committed r254627: <https://trac.webkit.org/changeset/254627>
Comment 6 WebKit Commit Bot 2020-01-15 12:19:04 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-01-15 12:20:19 PST 
<rdar://problem/58614689>