Bug 206259 - Regression r254533: iOS and mac build broken
Summary: Regression r254533: iOS and mac build broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-14 14:20 PST by Aakash Jain
Modified: 2020-01-14 15:30 PST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-01-14 14:20:38 PST 
r254533 seems to have broken iOS and mac builds.

e.g.:
https://build.webkit.org/builders/Apple%20Mojave%20Debug%20%28Build%29/builds/11790
https://build.webkit.org/builders/Apple%20iOS%2013%20Release%20%28Build%29/builds/3286


Relevant build error:/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.1.sdk/usr/include/objc/runtime.h:634:47: error: reference to 'Protocol' is ambiguous
Comment 1 Ryan Haddad 2020-01-14 14:26:35 PST 
In file included from /Volumes/Data/slave/mojave-debug/build/WebKitBuild/Debug/DerivedSources/WebKit2/unified-sources/UnifiedSource55.cpp:1:
/Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.cpp:42:17: error: member access into incomplete type 'WebKit::CtapDriver'
        m_driver->cancel();
                ^
In file included from /Volumes/Data/slave/mojave-debug/build/WebKitBuild/Debug/DerivedSources/WebKit2/unified-sources/UnifiedSource55.cpp:1:
In file included from /Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.cpp:27:
/Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.h:34:7: note: forward declaration of 'WebKit::CtapDriver'
class CtapDriver;
      ^
Comment 2 Jiewen Tan 2020-01-14 14:31:23 PST 
Committed r254535: <https://trac.webkit.org/changeset/254535>
Comment 3 Radar WebKit Bug Importer 2020-01-14 14:32:12 PST 
<rdar://problem/58582018>
Comment 4 Aakash Jain 2020-01-14 15:04:31 PST 
(In reply to Jiewen Tan from comment #2)
> Committed r254535: <https://trac.webkit.org/changeset/254535>
Build is still broken. e.g.: https://build.webkit.org/builders/Apple-Catalina-Release-Build/builds/2446
Comment 5 Alexey Proskuryakov 2020-01-14 15:30:28 PST 
Ryan reverted the change and the first build fix attempt.