Bug 206215 - Always Use CAIRO_OPERATOR_SOURCE to copyRectFromOneSurfaceToAnother
Summary: Always Use CAIRO_OPERATOR_SOURCE to copyRectFromOneSurfaceToAnother
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-13 23:16 PST by Tomoki Imai
Modified: 2020-01-14 17:53 PST (History)
11 users (show)

See Also:

Attachments
patch to remove cairoOperator from copyRectFromOneSurfaceToAnother (6.47 KB, patch)
2020-01-13 23:20 PST, Tomoki Imai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomoki Imai 2020-01-13 23:16:55 PST 
Most of copyRectFromOneSurfaceToAnother callers passed CAIRO_OPERATOR_SOURCE not to blend.
BackingStoreBackendCairoImpl::scroll had copyRectFromOneSurfaceToAnother with the default cairoOperator CAIRO_OPERATOR_OVER,
but scrolling should use CAIRO_OPERATOR_SOURCE because there is no need to blend and it can have a performance benefit.

copyRectFromOneSurfaceToAnother callers;
- https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp?rev=254496#L68
- https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp?rev=254496#L69
- https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp?rev=254496#L72
- https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp?rev=254496#L489
- https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp?rev=254496#L653
Comment 1 Tomoki Imai 2020-01-13 23:20:39 PST 
Created attachment 387624 [details]
patch to remove cairoOperator from copyRectFromOneSurfaceToAnother
Comment 2 WebKit Commit Bot 2020-01-14 02:01:14 PST 
Comment on attachment 387624 [details]
patch to remove cairoOperator from copyRectFromOneSurfaceToAnother

Clearing flags on attachment: 387624

Committed r254502: <https://trac.webkit.org/changeset/254502>
Comment 3 WebKit Commit Bot 2020-01-14 02:01:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-01-14 02:02:15 PST 
<rdar://problem/58562059>
Comment 5 Tomoki Imai 2020-01-14 17:53:50 PST 
Thanks for your reviews!