Bug 206187 - [JSC] Put JSProxy in IsoSubspace
Summary: [JSC] Put JSProxy in IsoSubspace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-13 12:23 PST by Yusuke Suzuki
Modified: 2020-01-13 13:29 PST (History)
11 users (show)

See Also:

Attachments
Patch (16.97 KB, patch)
2020-01-13 12:24 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (17.44 KB, patch)
2020-01-13 12:33 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Patch (17.66 KB, patch)
2020-01-13 12:35 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-01-13 12:23:12 PST 
[JSC] Put JSProxy in IsoSubspace
Comment 1 Yusuke Suzuki 2020-01-13 12:24:55 PST 
Created attachment 387556 [details]
Patch
Comment 2 Yusuke Suzuki 2020-01-13 12:33:06 PST 
Created attachment 387558 [details]
Patch
Comment 3 Yusuke Suzuki 2020-01-13 12:35:35 PST 
Created attachment 387559 [details]
Patch
Comment 4 Mark Lam 2020-01-13 12:46:23 PST 
Comment on attachment 387558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387558&action=review

r=me

> Source/JavaScriptCore/runtime/JSStringIterator.h:28
> -#include "JSObject.h"
> +#include "JSInternalFieldObjectImpl.h"

Seems unrelated.  Is this needed for a build fix?  If not, can you land this separately?  rs=me for that patch if needed.
Comment 5 Mark Lam 2020-01-13 12:47:45 PST 
Comment on attachment 387559 [details]
Patch

r=me with comment from https://bugs.webkit.org/show_bug.cgi?id=206187#c4
Comment 6 Yusuke Suzuki 2020-01-13 12:55:52 PST 
Comment on attachment 387558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387558&action=review

>> Source/JavaScriptCore/runtime/JSStringIterator.h:28
>> +#include "JSInternalFieldObjectImpl.h"
> 
> Seems unrelated.  Is this needed for a build fix?  If not, can you land this separately?  rs=me for that patch if needed.

Yes, this is required to fix the build. This patch removes a file, changing unified builds combination and breaking it.
Comment 7 Yusuke Suzuki 2020-01-13 13:28:50 PST 
Committed r254447: <https://trac.webkit.org/changeset/254447>
Comment 8 Radar WebKit Bug Importer 2020-01-13 13:29:16 PST 
<rdar://problem/58541273>